Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(buttons): large ButtonSizes height #71

Merged
merged 2 commits into from
Jan 17, 2023
Merged

fix(buttons): large ButtonSizes height #71

merged 2 commits into from
Jan 17, 2023

Conversation

corentin-stamper
Copy link
Contributor

Changes description 🧑‍💻

  • Updates large ButtonSizes height (64.dp to 56.dp)

Context 🤔

Closes #68

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

@corentin-stamper corentin-stamper requested review from a team as code owners January 13, 2023 16:03
@CLAassistant
Copy link

CLAassistant commented Jan 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/3c35dbc8-298b-403a-a0e7-31a0c3ed14ca/artifact/b5d459e3379b5885/p/717600fe429eb2e0df9d87b1333587d3

@ManonPolle ManonPolle requested a review from a team January 13, 2023 16:14
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/c1043e67-b8f7-4c11-a337-b6db265d9b2c/artifact/6f595da3a6ed29a4/p/6c940d5c318d794424a0e25427770b7f

@lauthieb lauthieb added run 💨 enhancement 🚀 New feature or request labels Jan 17, 2023
@lauthieb
Copy link
Member

Hi @corentin-stamper, thanks for your proposal.
As mentioned here, can you please sign the CLA?

@SimonLeclercq
Copy link

👍

@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/314333ed-50db-49a6-b7b2-68f0ce0ce356/artifact/9a0096369bfcf2e9/p/bf220ff579a6469e009bdaa5648d47e2

@ManonPolle ManonPolle merged commit c87dbf7 into Decathlon:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FDELAHA24 FDELAHA24 FDELAHA24 left review comments

@ManonPolle ManonPolle ManonPolle approved these changes

@SimonLeclercq SimonLeclercq SimonLeclercq approved these changes

Assignees

@corentin-stamper corentin-stamper

Labels
enhancement 🚀 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(button): Wrong large button height
7 participants
@corentin-stamper @CLAassistant @dktbitrise @lauthieb @SimonLeclercq @ManonPolle @FDELAHA24