Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: update CODEOWNERS #73

Merged
merged 1 commit into from
Jan 17, 2023
Merged

config: update CODEOWNERS #73

merged 1 commit into from
Jan 17, 2023

Conversation

lauthieb
Copy link
Member

@lauthieb lauthieb commented Jan 17, 2023 •
edited
Loading

Changes description 🧑‍💻

Hello,
I propose to update CODEOWNERS to replace core team developers (which includes web, android, etc.) by the current technical lead. Thanks. Laurent

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

@lauthieb
config: update CODEOWNERS
caf8e92 
Hello,
I propose to update CODEOWNERS to replace core team developers (which includes web, android, etc.) by the current technical lead. Thanks. Laurent
@lauthieb lauthieb added the config 🛠 Related to configuration label Jan 17, 2023
@lauthieb lauthieb requested a review from a team as a code owner January 17, 2023 07:46
@lauthieb lauthieb self-assigned this Jan 17, 2023
@lauthieb lauthieb requested a review from a team as a code owner January 17, 2023 07:46
@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/b41797d5-5f9a-47ad-ae33-659f61e41f10/artifact/0dff055f8e1b6ff4/p/41203f12357b3738cc5cf73292b424a0

@ManonPolle ManonPolle merged commit 9c66a81 into main Jan 17, 2023
@ManonPolle ManonPolle deleted the config/codeowners branch January 17, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManonPolle ManonPolle ManonPolle approved these changes

Assignees

@lauthieb lauthieb

Labels
config 🛠 Related to configuration
Projects
Decathlon Design System
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lauthieb @dktbitrise @ManonPolle