Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade libraries versions. #75

Merged
merged 1 commit into from
Jan 27, 2023
Merged

chore: Upgrade libraries versions. #75

merged 1 commit into from
Jan 27, 2023

Conversation

corentin-stamper
Copy link
Contributor

@corentin-stamper corentin-stamper commented Jan 20, 2023 •
edited
Loading

Changes description 🧑‍💻

Psst ! Compose 1.3 is coming

Closes #66

Context 🤔

library old version new version
Android Gradle plugin 7.3.1 7.4.0
Kotlin Gradle plugin 1.7.0 1.7.20
compileSdk 32 33
vitamin-android 0.4.0 0.5.0-beta01
navigation 2.4.2 2.5.3
activity 1.4.0 1.6.1
appcompat 1.4.2 1.6.0
compose 1.2.0 1.3.2
accompanist 0.25.0 0.28.0
androidx-core 1.8.0 1.9.0
androidx-lifecycle 2.4.1 2.5.1
androidx-savedstate 1.1.0 1.2.0
espresso 3.5.0 3.5.1
junit 1.1.4 1.1.5
material 1.6.1 1.7.0

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

@CLAassistant
Copy link

CLAassistant commented Jan 20, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@corentin-stamper corentin-stamper added the config 🛠 Related to configuration label Jan 20, 2023
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/64351baf-5b73-4511-abf0-97973aa235d3/artifact/15f1c1951dbdda80/p/c8d636a58d74fd8357a2f0b727765466

ManonPolle
ManonPolle previously approved these changes Jan 27, 2023
View reviewed changes
GerardPaligot
GerardPaligot previously approved these changes Jan 27, 2023
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/aa5d642e-8d74-486d-97c8-7fdbd15991d2/artifact/92cf5cb619216160/p/24ef60eecfe1ecadbe50854bfd46097c

@corentin-stamper corentin-stamper merged commit 1c3531a into Decathlon:main Jan 27, 2023
@corentin-stamper corentin-stamper deleted the chore/versions-2 branch January 27, 2023 15:53
@ManonPolle ManonPolle added this to the 0.3.0 Version milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManonPolle ManonPolle ManonPolle approved these changes

@GerardPaligot GerardPaligot GerardPaligot left review comments

Assignees
No one assigned
Labels
config 🛠 Related to configuration
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Can't update Compose version to 1.3
5 participants
@corentin-stamper @CLAassistant @dktbitrise @GerardPaligot @ManonPolle