Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(buttons): Fix Ripple Theme on Buttons #76

Merged
merged 1 commit into from
Jan 27, 2023
Merged

fix(buttons): Fix Ripple Theme on Buttons #76

merged 1 commit into from
Jan 27, 2023

Conversation

ManonPolle
Copy link
Contributor

@ManonPolle ManonPolle commented Jan 23, 2023 •
edited
Loading

Changes description 🧑‍💻

Vitamin Ripple Theme make button not accessible. I remvoved Vitamin ripple override and let Material one by default.

Can close #56
Can close #57

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots 📸

image

image

Other info 👋

@ManonPolle ManonPolle added bug 🐛 Something isn't working run 💨 labels Jan 23, 2023
@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/52176034-320d-4082-967f-6bff3d9174c0/artifact/0f9865ae1b7c1ab7/p/30716f320226f086ddc7ad6fcafe928d

@ManonPolle ManonPolle marked this pull request as ready for review January 24, 2023 15:50
@ManonPolle ManonPolle requested a review from a team as a code owner January 24, 2023 15:50
@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/315a6086-acb7-45dd-b42f-89fad7a78681/artifact/735e800ecc2006c2/p/db556bc45bb40665e8821eba456bfaae

@ManonPolle ManonPolle merged commit 696abc2 into Decathlon:main Jan 27, 2023
@ManonPolle ManonPolle deleted the fix/ripple-buttons branch January 27, 2023 16:38
@ManonPolle ManonPolle added this to the 0.3.0 Version milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corentin-stamper corentin-stamper corentin-stamper approved these changes

@SimonLeclercq SimonLeclercq SimonLeclercq approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Wrong buttons colors with physical keyboard navigation The ripple effect does not match the design
4 participants
@ManonPolle @dktbitrise @corentin-stamper @SimonLeclercq