Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): manage tabItems size #78

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

corentin-stamper
Copy link
Contributor

Changes description πŸ§‘β€πŸ’»

  • throw IllegalArgumentException when tabItems contains less than 2 items.

Context πŸ€”

Closes #72

Checklist βœ…

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Other info πŸ‘‹

    java.lang.IllegalArgumentException: tabItems must have at least 2 items
        at com.decathlon.vitamin.compose.tabs.VitaminTabs.validateTabItems(VitaminTabs.kt:119)
        at com.decathlon.vitamin.compose.tabs.VitaminTabs.Fixed-kKmfEb0(VitaminTabs.kt:35)

@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2023

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dktbitrise
Copy link

@ManonPolle ManonPolle merged commit dd1dfc4 into Decathlon:main Jan 30, 2023
@ManonPolle ManonPolle added this to the 0.3.0 Version milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix - in VitaminTabs, if the list provided is empty, the exception 'NoSuchElementException' is thrown
3 participants