Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enforce title color when title is set to avoid weird behaviours #102

Merged
merged 1 commit into from
Dec 27, 2022
Merged

fix: enforce title color when title is set to avoid weird behaviours #102

merged 1 commit into from
Dec 27, 2022

Conversation

daniel-dumortier
Copy link
Contributor

@daniel-dumortier daniel-dumortier commented Dec 16, 2022 •
edited
Loading

Changes description

When title is set, we re-enforce the title color to avoid weird effects like described in #101

Context

fixes #101

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on an iPhone device/simulator.
  • I have tested on an iPad device/simulator.
  • If it includes design changes, please ask for a review with a core team designer.

Does this introduce a breaking change?

  • No

@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@florentlotthepro florentlotthepro added the bug 🐛 Something isn't working label Dec 16, 2022
@daniel-dumortier daniel-dumortier merged commit 97a11f3 into main Dec 27, 2022
@daniel-dumortier daniel-dumortier deleted the fix/uikit_vitaminbutton_titlecolor branch December 27, 2022 10:38
@daniel-dumortier daniel-dumortier mentioned this pull request Feb 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florentlotthepro florentlotthepro florentlotthepro approved these changes

@lauthieb lauthieb Awaiting requested review from lauthieb

@baptistedajon baptistedajon Awaiting requested review from baptistedajon

Assignees
No one assigned
Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: textColor on button changes when title is changed
2 participants
@daniel-dumortier @florentlotthepro