-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SegmentedControl UIKit implementation #115
Conversation
Hey @daniel-dumortier, Feel free to discuss with @florentlotthepro about the component name. Keep in mind that we want to stay as close as possible to the developer's experience of the platform. On the Design side, this component is named |
@daniel-dumortier I'm not able to find the bitrise link 🤔 Can you help me? 😎 |
@SimonLeclercq the showcase has not been built yet, that's why you can't find the link ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like said by Simon, what do you think about VitaminSegmentedControl
? (and VitaminSegmentedController
) It's not exactly like Vitamin Android but it feels more iOS. For me, Tabs feels like related to TabBar
.
Sources/VitaminUIKit/Components/Tabs/VitaminTabsController.swift
Outdated
Show resolved
Hide resolved
Sources/VitaminUIKit/Components/Tabs/VitaminTabsController.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it could be nice to also rename the folder for the component 😇
@SimonLeclercq The build is available, you can find the link on Slack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I see a slight horizontal shift on the labeltext compared to the container. Can you confirm this? Besides that, it's good for me.
@SimonLeclercq |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Ok so no problem 👍 thanks for feedback ! |
Changes description
Implementation of Vitamin tab component for UIKit.
It is a subclass of standard UISegmentedControl, with only customization of:
The PR also contains a
VitaminTabsController
that handles a common use case : display aVitaminTabs
at the top of the screen, and a viewController below, depending on the tab selectedContext
UIKit part of #41
Checklist
design-system-core-team-design
GitHub team.Does this introduce a breaking change?
Screenshots
iPhone
iPad
Other information
I named the component
VitaminTab
, but I wonder if it should not been namedVitaminSegmentedControl
, that would be more understandable by iOS developers.