feat(button): add icon alone UIKit VitaminButton type, and refactor icon management #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 22, 2022
florentlotthepro
previously approved these changes
Jul 22, 2022
Co-authored-by: Florent LOTTHÉ <[email protected]>
daniel-dumortier
changed the title
Co-authored-by: Florent LOTTHÉ <[email protected]>
florentlotthepro
approved these changes
Jul 25, 2022
daniel-dumortier
added
the
Ready for Design Review
|
👍 |
|
Kudos, SonarCloud Quality Gate passed!
|
daniel-dumortier
removed
the
Ready for Design Review
|
Some problems have been detected on existing buttons, but since they are already released, I just opened a new issue #77 and merge this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes description
I added the ability to define a 'icon Alone' version of VitaminButton.
I also reworked the way to specify which type of icon you want (for already existing trailing and leading icons)
And I took advantage of this PR to change icon size on large and medium button (see #74)
Context
Checklist
Does this introduce a breaking change?
I deprecated some methods, but they are still usable, the will just raise a warning.
Screenshots
iPhone
iPad
Other information
I am not sure it is Vitamin compliant, but I reworked the code to give the ability to have different icons for different states (that was allowed before by the previous code, but did not work well)