fix(@vtmn/svelte): VtmnListItem tabindex can be false (#1490)

Decathlon · Mar 25, 2024 · 473474e · 473474e
1 parent 9867a64
commit 473474e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/sources/svelte/src/components/structure/VtmnListItem/VtmnListItem.svelte b/packages/sources/svelte/src/components/structure/VtmnListItem/VtmnListItem.svelte
@@ -103,7 +103,7 @@
   {#if href}
     <a
       class="vtmn-list__link"
-      tabindex={disabled && -1}
+      tabindex={disabled ? -1 : 0}
       {href}
       {target}
       on:click|stopPropagation

diff --git a/packages/sources/svelte/src/components/structure/VtmnListItem/test/VtmnListItem.spec.js b/packages/sources/svelte/src/components/structure/VtmnListItem/test/VtmnListItem.spec.js
@@ -88,6 +88,7 @@ describe('VtmnListItem', () => {
     });
     expect(getByRole('link')).toHaveAttribute('href', 'https://decathlon.fr');
     expect(getByRole('link')).toHaveAttribute('aria-disabled', 'true');
+    expect(getByRole('link')).toHaveAttribute('tabindex', '-1');
   });
   test('Should have a link _blank with noopener noreferrer', () => {
     const { getByRole } = render(VtmnListItem, {
@@ -96,5 +97,6 @@ describe('VtmnListItem', () => {
     expect(getByRole('link')).toHaveAttribute('href', 'https://decathlon.fr');
     expect(getByRole('link')).toHaveAttribute('target', '_blank');
     expect(getByRole('link')).toHaveAttribute('rel', 'noopener noreferrer');
+    expect(getByRole('link')).toHaveAttribute('tabindex', undefined);
   });
 });