Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vtmn/svelte): change vtmnChip in order to set a different type of node #1479

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

Tlahey
Copy link
Contributor

@Tlahey Tlahey commented Jan 25, 2024

Changes description

Switch the default div element to a svelte:element with by default div value
Add the restProps inside the component.

Context

In some cases, the VtmnChip can be a link (for apply a filter -> redirect to a new page ...)
Today, if we want to apply a chip with a redirect, we have to wrap it inside a <a> tag like that

<a>
  <VtmnChip />
</a>

But this way introduce a issue with a double focus and a bad semantic (link with a button inside)
So that why I propose to move to a `svelte:element

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on related showcases.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Does this introduce a breaking change?

  • No breaking changes for the PR :)

Other information

@Tlahey Tlahey requested review from thibault-mahe and a team as code owners January 25, 2024 15:30
@Tlahey Tlahey added enhancement 🚀 New feature or request Svelte 🟠 Related to Svelte components library community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community labels Jan 25, 2024
@Tlahey Tlahey changed the title feat(vtmn/svelte): change vtmnChip in order to set a different type of node feat(vtmn/svelte): change vtmnChip in order to set a different type of node Jan 25, 2024
@lauthieb lauthieb merged commit 7516a55 into main Jan 25, 2024
8 checks passed
@lauthieb lauthieb deleted the feat/vtmnChip-change-default-node branch January 25, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community enhancement 🚀 New feature or request Svelte 🟠 Related to Svelte components library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants