Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@vtmn/svelte, @vtmn/css): fix timeout on overlays components #1480

Merged
merged 4 commits into from
Feb 12, 2024
Merged

fix(@vtmn/svelte, @vtmn/css): fix timeout on overlays components #1480

merged 4 commits into from
Feb 12, 2024

Conversation

Tlahey
Copy link
Contributor

@Tlahey Tlahey commented Feb 9, 2024 •
edited
Loading

Changes description

Today the timeout inside the VtmnAlert / VtmnSnackbar / VtmnToast are broken.

Thanks to this fix, it is possible to apply a timeout from 1ms to Infinity on those components without breaking changes !

image

Fix also an issue with a large text

Context

On NFS it is not possible to apply an alert more than 8s.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on related showcases.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Does this introduce a breaking change?

  • No

Other information

@Tlahey Tlahey requested review from thibault-mahe and a team as code owners February 9, 2024 16:51
@Tlahey Tlahey added enhancement 🚀 New feature or request Svelte 🟠 Related to Svelte components library community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community CSS 🎨 Related to CSS styles packages labels Feb 9, 2024
@Tlahey Tlahey mentioned this pull request Feb 12, 2024
Closed
@thibault-mahe thibault-mahe merged commit 15ccc52 into main Feb 12, 2024
5 checks passed
@thibault-mahe thibault-mahe deleted the fix/overlays-timeout branch February 12, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-mahe thibault-mahe thibault-mahe approved these changes

Assignees
No one assigned
Labels
community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community CSS 🎨 Related to CSS styles packages enhancement 🚀 New feature or request Svelte 🟠 Related to Svelte components library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tlahey @thibault-mahe