Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@vtmn/svelte): add property for ol attributes VtmnBreadcrumb #1481

Merged
merged 1 commit into from
Feb 12, 2024
Merged

feat(@vtmn/svelte): add property for ol attributes VtmnBreadcrumb #1481

merged 1 commit into from
Feb 12, 2024

Conversation

Tlahey
Copy link
Contributor

@Tlahey Tlahey commented Feb 12, 2024 •
edited
Loading

Changes description

Add new input in order to set properties on the <ol> node.

Context

Missing accessibility properties like aria-label

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on related showcases.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Does this introduce a breaking change?

  • No

Other information

@Tlahey Tlahey added enhancement 🚀 New feature or request Svelte 🟠 Related to Svelte components library community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community labels Feb 12, 2024
@Tlahey Tlahey requested review from thibault-mahe and a team as code owners February 12, 2024 10:53
@Tlahey Tlahey changed the title feat(@vtmn/svelte): add property for ol attributes feat(@vtmn/svelte): add property for ol attributes VtmnBreadcrumb Feb 12, 2024
@thibault-mahe thibault-mahe merged commit 97f3245 into main Feb 12, 2024
8 checks passed
@thibault-mahe thibault-mahe deleted the feat/add-breadcrumb-ol-attributes branch February 12, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-mahe thibault-mahe thibault-mahe approved these changes

Assignees
No one assigned
Labels
community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community enhancement 🚀 New feature or request Svelte 🟠 Related to Svelte components library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tlahey @thibault-mahe