Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@vtmn/svelte): fix dispatch close for VtmnAlertItem / VtmnSnackbarItem / VtmnToastItem #1486

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix(@vtmn/svelte): fix dispatch close for VtmnAlertItem / VtmnSnackbarItem / VtmnToastItem #1486

merged 1 commit into from
Feb 27, 2024

Conversation

Tlahey
Copy link
Contributor

@Tlahey Tlahey commented Feb 27, 2024 •
edited
Loading

Changes description

The close dispatch is send even if the user has set a timeout to 0.
This PR fix this behaviour.

Context

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on related showcases.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Does this introduce a breaking change?

  • No

Other information

@Tlahey Tlahey requested review from thibault-mahe and a team as code owners February 27, 2024 09:48
@Tlahey Tlahey added bug 🐛 Something isn't working Svelte 🟠 Related to Svelte components library community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community labels Feb 27, 2024
@thibault-mahe thibault-mahe merged commit cdd09b2 into main Feb 27, 2024
7 checks passed
@thibault-mahe thibault-mahe deleted the fix/alert-timeout-dispatch branch February 27, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-mahe thibault-mahe thibault-mahe approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community Svelte 🟠 Related to Svelte components library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tlahey @thibault-mahe