Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to HDF5 metadata #192

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

jsoishi
Copy link
Member

@jsoishi jsoishi commented Apr 26, 2022

@jsoishi jsoishi requested a review from kburns April 26, 2022 14:49
@kburns
Copy link
Member

kburns commented Apr 26, 2022

Looks good. Only issue I can think of is that this could be misleading if we save vectors or tensors in coeff space, since there the coefficients may correspond to spin/regularity components, not the coordinate components like in grid space.

@jsoishi
Copy link
Member Author

jsoishi commented Apr 26, 2022

That's a good point. We could do something like s_1/2, s_-1/2, r_0, r_1, etc in that case, basis dependent?

@kburns
Copy link
Member

kburns commented Apr 26, 2022

Yeah or maybe just {-1, 0, +1} or even {-, 0, +}, and you have to know its spin or regularity based on the context? Any thoughts @lecoanet?

@lecoanet
Copy link
Member

Our ordering is {-, +, 0}. Using {-, +, 0} for both spin and regularity bases would be fine. But {s-, s+, s0} and {r-, r+, r0} might be a bit more descriptive. Don't think we ever have spin 1/2.

@jsoishi
Copy link
Member Author

jsoishi commented Apr 27, 2022 via email

@kburns
Copy link
Member

kburns commented Apr 28, 2022

@jsoishi want to push this to a separate branch on the main repo?

@kburns
Copy link
Member

kburns commented Apr 28, 2022

Marking as a draft since we're still WIP.

@kburns kburns marked this pull request as draft April 28, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants