Fixes virtual file merge logic & removes deprecated distributed set merge logic #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be possible to simply merge virtual datasets into concrete datasets within the existing set file using the |
|
Hi Keaton, I didn't know about that method! I'll take a look and try to get that implemented. I've marked the PR as a draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #205 and updates post.py to reflect Dedalus' new output paradigm by removing deprecated functions for merging partial files. Functionality for merging partial files => complete files after a simulation is updated. Tests have been added for each of the new parallel output types ('virtual', 'mpio', 'gather').
All output and parallel output tests now pass. There are some failing ncc tests, but those should be unaffected by these commits.