Attempt to fix regularity recombination when array has size 0 #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI
I encountered a problem a while a go with a code involving the transpose of the velocity gradient
d3.trans(d3.grad(u)). The forward and backwards regularity recombination functions throw an error if data.shape has a zero in the first location, which can occur when using transposes.A minimal working example is attached which crashes when run with four processors. This same error occurs on much larger resolution problems when the number of processors is large.
This pull request proposes a simple fix by being more specific in how the gdata array is reshaped, as it seems that the (-1,) part of the reshape may be the cause of this issue.
Best,
Calum
mwe.txt