Polar components on tensors #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VascoSch92
reviewed
Jun 19, 2024
| input_dim = len(operand.tensorsig) | ||
| output_dim = len(self.tensorsig) | ||
| matrix = [] | ||
| for output in range(2**output_dim): |
There was a problem hiding this comment.
you can vectorise this part with numpy instead of using two for loops
There was a problem hiding this comment.
How would you suggest that we vectorize this?
lecoanet
force-pushed
the
polar_components
branch
from
94f5f0c
to
8c92ec6
Compare
|
@kburns I had intended to add some tests to this, but it is pretty tricky to set up a test for this type of problem (non-square operator). So I think we might want to just merge this in directly. Thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the polar component operators (PolarRadialComponent and PolarAzimuthalComponent) assume they are acting on vectors. This PR allows the operators to act on tensors.