Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#81: Make sure that data can be matched for Cesium platform #82

Merged
merged 38 commits into from
Apr 19, 2024
Merged

#81: Make sure that data can be matched for Cesium platform #82

merged 38 commits into from
Apr 19, 2024

Conversation

priscavdsluis
Copy link
Collaborator

No description provided.

@priscavdsluis
Support xy-coordinate transformation to a different CRS
fd7a6b6
@priscavdsluis
Add test for crs transformation
adcb6ef
@priscavdsluis
Add test for crs transformation
6dc7287
@priscavdsluis
Explicitly add pyproj as dependency
a77e3e3
@priscavdsluis
Add extra parameter variables to transform_coordinate_system function
ac03b36
@priscavdsluis
Enable retrieval of grid files over network
221c00e
@priscavdsluis
Extract function
5007df3
@priscavdsluis
Transform z-coordinates for all variables.
e627a7f
@priscavdsluis
Extract two properties
e651865
@priscavdsluis
Refactor functions
ba9a32c
@priscavdsluis
Add new shifting configuration for custom shifting
8a56294
@priscavdsluis
Make sure that custom shift settings are used
d63d56b
@priscavdsluis
Add extra parameters shift_z and variables to shift_coordinates f…
09ea84a 
…unctions.
@priscavdsluis
Add shift_z to configuration
8d4aab1
@priscavdsluis
Restructure functions
63b05e8
@priscavdsluis
Fix signature change
46fe0f7
@priscavdsluis
Configure logging
172e741
@priscavdsluis
Use tmp_path fixture instead of own implemented get_temp_file
acaae18
@priscavdsluis
Add function to create a coordinate system transformer
b61d9db
@priscavdsluis
Rename logfile
59a3cee
@priscavdsluis
Make sure shift values can be transformed to the model CRS
58fcaa8
@priscavdsluis
Update Westerschelde test case
26d6832
@priscavdsluis
Remove transform_coordinate_system function
40fddf9
@priscavdsluis
Make sure variables values are also shifted for XBEACH data.
17a9617
@priscavdsluis
Update readme.md
377f938
@priscavdsluis priscavdsluis changed the title 81: Make sure that data can be matched for Cesium platform #81: Make sure that data can be matched for Cesium platform Feb 29, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
91.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@priscavdsluis priscavdsluis linked an issue Apr 11, 2024 that may be closed by this pull request
Support workflow for correctly matching the data with a Cesium context #81
Closed
MRVermeulenDeltares
MRVermeulenDeltares reviewed Apr 12, 2024
View reviewed changes
Copy link

@MRVermeulenDeltares MRVermeulenDeltares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, some questions more than feedback.
Mainly because I do not know ceirtain things.
Lets discuss.

One final question: How should this issue be tested?

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@priscavdsluis
Copy link
Collaborator Author

@MRVermeulenDeltares, as for your last question: issue will essentially be tested by Connec2 as they will work with the resulting file.

@priscavdsluis priscavdsluis merged commit f5ec8e0 into main Apr 19, 2024
7 checks passed
@priscavdsluis priscavdsluis deleted the 81-match-data-for-cesium branch April 19, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MRVermeulenDeltares MRVermeulenDeltares MRVermeulenDeltares left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support workflow for correctly matching the data with a Cesium context
2 participants
@priscavdsluis @MRVermeulenDeltares