Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#42: Rotate the model such that the Y and Z axes are switched so that Y is up #86

Merged
merged 3 commits into from
May 2, 2024

Conversation

priscavdsluis
Copy link
Collaborator

No description provided.

@priscavdsluis priscavdsluis linked an issue May 2, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented May 2, 2024

Copy link

@MRVermeulenDeltares MRVermeulenDeltares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look Ok I think.

Question: The y and z axes will always be hardcoded rotated, this is because the input data always will deliver it in such a way that it needs to be rotated?
Is there a case in which it is possible that the data does not need to be rotated?

Note: my approve has no effect, since I do not have write access to the repo, my approve is ignored for the merging blockade.

@priscavdsluis
Copy link
Collaborator Author

Look Ok I think.

Question: The y and z axes will always be hardcoded rotated, this is because the input data always will deliver it in such a way that it needs to be rotated? Is there a case in which it is possible that the data does not need to be rotated?

Note: my approve has no effect, since I do not have write access to the repo, my approve is ignored for the merging blockade.

Yes, with our data it should always be rotated.

@priscavdsluis priscavdsluis merged commit 1b6e07c into main May 2, 2024
3 checks passed
@priscavdsluis priscavdsluis deleted the feature/42-flip-y-and-z branch May 2, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flip y and z axes such that y is up (instead of z)
2 participants