Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#42: Rotate the model 179 degrees around the up-axis #87

Merged
merged 2 commits into from
May 21, 2024

Conversation

priscavdsluis
Copy link
Collaborator

No description provided.

@priscavdsluis priscavdsluis linked an issue May 21, 2024 that may be closed by this pull request
0, 1, 0, 0,
0, 0, 0, 1]
"""Rotation matrix to flip the y and z axes."""
ROTATION_MATRIX = [-0.9998477, 0, 0.0174524, 0,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an explanation why it is supposed to change written down here:
Flip y and z axes such that y is up (instead of z) 179 degrees.pdf

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ralph :D

Copy link

@ralph-peelen-deltares ralph-peelen-deltares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When reading implementation change in attachment it is clear why the values have changed. This issue is implemented correctly.

@ralph-peelen-deltares
Copy link

please resolve failing checks.

Copy link

sonarcloud bot commented May 21, 2024

@priscavdsluis priscavdsluis merged commit dde7fc9 into main May 21, 2024
3 checks passed
@priscavdsluis priscavdsluis deleted the feature/42-rotate-model-179-degrees branch May 21, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flip y and z axes such that y is up (instead of z)
2 participants