Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor's Logo and Addition of Preloader #214

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

Anjaliavv51
Copy link
Contributor

@Anjaliavv51 Anjaliavv51 commented Jun 1, 2024

issue #210
issue #211

Description

Addition contributor's Logo and Preloader.

Fixes: #210 and #211

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have made this from my own
  • I have taken help from some online resourses
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK (if applicable)

image

20240601-1419-18.6220332.mp4

Copy link

github-actions bot commented Jun 1, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Anjaliavv51 Anjaliavv51 changed the title Contributor's Logo Contributor's Logo and Addition of Preloader Jun 1, 2024
@Anjaliavv51
Copy link
Contributor Author

@Dev-tanay please review the PR

@Dev-tanay
Copy link
Owner

Dev-tanay commented Jun 1, 2024

Changing the Preloader is possible with a cube? @Anjaliavv51

@Anjaliavv51
Copy link
Contributor Author

Anjaliavv51 commented Jun 2, 2024

Yes sure @Dev-tanay

@Anjaliavv51
Copy link
Contributor Author

Anjaliavv51 commented Jun 2, 2024

@Dev-tanay please review the changes
@Dev-tanay i made the changes and also this PR containes both issues of #210 and #211
i think if possible u can add level 2 label to the PR #214

@Anjaliavv51
Copy link
Contributor Author

@Dev-tanay

@Anjaliavv51
Copy link
Contributor Author

@Dev-tanay please review the Pr

@Dev-tanay
Copy link
Owner

Please attach a video @Anjaliavv51

@Anjaliavv51
Copy link
Contributor Author

image

20240601-1419-18.6220332.mp4

@Anjaliavv51
Copy link
Contributor Author

@Dev-tanay please see the above attached videos

@Anjaliavv51
Copy link
Contributor Author

@Dev-tanay please see the attached video

@Anjaliavv51
Copy link
Contributor Author

@Dev-tanay please review the changes
@Dev-tanay i made the changes and also this PR containes both issues of #210 and #211
i think if possible u can add level 2 label to the PR #214

@Anjaliavv51
Copy link
Contributor Author

@Dev-tanay please review the PR

@Dev-tanay Dev-tanay merged commit 891cfed into Dev-tanay:main Jul 22, 2024
@Anjaliavv51
Copy link
Contributor Author

@Dev-tanay please add level 2 label as it contains both , addition of Preloader and contributors logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributor's Logo
2 participants