Prevent valueChanges event when patchValue method is used with emitEvent=false #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovchinnikov
suggested changes
Mar 13, 2018
tests/src/core/component.spec.ts
Outdated
| @@ -194,6 +194,23 @@ describe('DevExtreme Angular widget', () => { | |||
| expect(testSpy).toHaveBeenCalledTimes(1); | |||
| })); | |||
|
|
|||
| it('should not emit testOptionChange event when changes happen in component (T614207)', async(() => { | |||
There was a problem hiding this comment.
Is there any reason to make this test asynchronous?
There was a problem hiding this comment.
No, I will fix it
ovchinnikov
reviewed
Mar 14, 2018
src/core/component.ts
Outdated
| @@ -93,6 +93,15 @@ export abstract class DxComponent implements OnChanges, OnInit, DoCheck, AfterCo | |||
| this.instance.endUpdate(); | |||
| } | |||
| } | |||
| lockEventFire(name: string) { | |||
| this.eventHelper.lockEventFire.push(name + 'Change'); | |||
There was a problem hiding this comment.
Is it necessary to have an array here? It seems that it's impossible to have several locked events simultaneously
There was a problem hiding this comment.
I found the case, where we have two events in the array, but it's checked in the correct order. So, we can get rid of array here.
ovchinnikov
approved these changes
Mar 20, 2018
nightskylark
approved these changes
Mar 20, 2018
anna-zhernovkova
added a commit
that referenced
this pull request
Mar 20, 2018
) * Prevent option change event firing when changes occur in component * Update event lockers * Fix typo * Add test for bound options * Simplify lockers * Refactor test * Prevent option change event firing when nested option was changed * Move event locker to writeValue method * Rework test * Fix typo
anna-zhernovkova
added a commit
that referenced
this pull request
Mar 20, 2018
) (#717) * Prevent option change event firing when changes occur in component * Update event lockers * Fix typo * Add test for bound options * Simplify lockers * Refactor test * Prevent option change event firing when nested option was changed * Move event locker to writeValue method * Rework test * Fix typo
anna-zhernovkova
changed the title
dxvladislavvolkov
added a commit
to dxvladislavvolkov/devextreme-angular
that referenced
this pull request
Apr 10, 2018
…onent (DevExpress#712)" This reverts commit 1966c4e.
dxvladislavvolkov
added a commit
to dxvladislavvolkov/devextreme-angular
that referenced
this pull request
Apr 10, 2018
…onent (DevExpress#712) (DevExpress#717)" This reverts commit 08a40ba.
dxvladislavvolkov
added a commit
that referenced
this pull request
Apr 10, 2018
dxvladislavvolkov
pushed a commit
to dxvladislavvolkov/devextreme-angular
that referenced
this pull request
Apr 13, 2018
…evExpress#712) * Prevent option change event firing when changes occur in component * Update event lockers * Fix typo * Add test for bound options * Simplify lockers * Refactor test * Prevent option change event firing when nested option was changed * Move event locker to writeValue method * Rework test * Fix typo
dxvladislavvolkov
pushed a commit
to dxvladislavvolkov/devextreme-angular
that referenced
this pull request
Apr 13, 2018
…evExpress#712) (DevExpress#717) * Prevent option change event firing when changes occur in component * Update event lockers * Fix typo * Add test for bound options * Simplify lockers * Refactor test * Prevent option change event firing when nested option was changed * Move event locker to writeValue method * Rework test * Fix typo
dxvladislavvolkov
added a commit
that referenced
this pull request
Apr 13, 2018
) (#750) * Prevent option change event firing when changes occur in component * Update event lockers * Fix typo * Add test for bound options * Simplify lockers * Refactor test * Prevent option change event firing when nested option was changed * Move event locker to writeValue method * Rework test * Fix typo
dxvladislavvolkov
added a commit
that referenced
this pull request
Apr 13, 2018
) (#717) (#749) * Prevent option change event firing when changes occur in component * Update event lockers * Fix typo * Add test for bound options * Simplify lockers * Refactor test * Prevent option change event firing when nested option was changed * Move event locker to writeValue method * Rework test * Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix T614207