Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titles show in queue after queue cleared #88

Closed
WillerZ opened this issue Feb 24, 2024 · 3 comments
Closed

Titles show in queue after queue cleared #88

WillerZ opened this issue Feb 24, 2024 · 3 comments

Comments

@WillerZ
Copy link

WillerZ commented Feb 24, 2024

I see track names etc behind the "All is quiet now" messaging. Looks like maybe UI table row objects are being recycled and not cleared before reuse.

@WillerZ
Copy link
Author

WillerZ commented Feb 24, 2024

Attaching some screenshots so you can see what I'm talking about and to some extent verify whether I've done something weird.

Initial queue looks OK:

image

After adding some songs looks OK:
image

After clearing looks broken:
image

Interestingly I was still able to scroll the queue pane for a few seconds after clearing it, and that seems to be why the songs in the post-clearing screenshot don't match the ones in the pre-clearing screenshot.

@Difegue
Copy link
Owner

Difegue commented Mar 2, 2024

Weird, I'll look into this at some point. Thanks for the report!

Difegue added a commit that referenced this issue Mar 28, 2024
@Difegue
Copy link
Owner

Difegue commented Mar 28, 2024

Can repro; I blame either WinUI or the toolkit on that one since things are cleaned up properly on the app side...
It's easy to hide the grid in any case, shouldve probably done that to begin with.

I'll have this fixed in the next release, thanks.

@Difegue Difegue closed this as completed Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants