Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit changes from 九万里而南为, Jul 18 #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jareguo
Copy link
Contributor

@jareguo jareguo commented Jul 30, 2018

帮九万里而南为提交了他的改动。随手移除了几个无用的属性。
现在的版本有一个问题:
为什么 CocosArmatureComponent 要创建一个子节点,然后在子节点挂一个 CocosArmatureComponent 进行驱动…… 是因为 CocosFactory 只能通过 buildArmature 创建骨架吗?不能加载一个场景里已有的组件吗?
感觉这样的逻辑很神奇…… 如果是这样的话,我建议的是 CocosArmatureComponent 内直接持有抽象的骨架对象(armature),而不是一个场景中额外的实体节点(cc.Node)

该 PR 可能还需要进一步 review。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant