Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Large ship deltas - 2.0 #10323

Merged
merged 3 commits into from
May 3, 2021
Merged

Large ship deltas - 2.0 #10323

merged 3 commits into from
May 3, 2021

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Apr 30, 2021

Change Description

Fix for #10228

  • Large SHiP deltas cause overflow of uint32_t
  • Updated to latest fc for 2.0 which includes a fix for variant blob_type
  • Thanks @tbfleming

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@heifner heifner mentioned this pull request Apr 30, 2021
12 tasks
Copy link
Contributor

@linhuang-blockone linhuang-blockone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test case for this (simulating large delta) in the future.

@heifner heifner merged commit e3524f1 into release/2.0.x May 3, 2021
@heifner heifner deleted the large-ship-2.0 branch May 3, 2021 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants