This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Sanitize Branch Names for Docker Containers #10374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IO_REGISTRY accidentally
…-agent pipeline upload
This was referenced May 17, 2021
scottarnette
approved these changes
May 17, 2021
williamblevins
approved these changes
May 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
From #help-automation and AUTO-848, a developer created an eos branch name with a hash tag
#character (e.g. "pr#125"). This broke theDocker - Build and Installstep because it requires branch names to be valid URIs, currently only transforming forward-slashes/into underscores_to support branch names with forward-slashes.This pull request adds a series of transforms to turn forward-slashes
/into underscores_, turn all other invalid characters for a docker container name into dashes-, then minimize sequences of these replacement characters and ensure they are not the beginning or end of the string.I have also added log folding groups and improved the patterns in
/.cicd/create-docker-from-binary.sh, and updated the pipeline readme.See Also
eos:developeos:release/2.1.xeos:release/2.0.xChange Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
None.
API Changes
None.
Documentation Additions
None.