This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
fixed get_kv_table_rows issues #9743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimjh2005
commented
Dec 4, 2020
| @@ -2219,6 +2220,7 @@ read_only::get_table_rows_result read_only::get_kv_table_rows_context( const rea | |||
| const string &index_value = *p.index_value; | |||
| p.lower_bound = p.index_value; | |||
| unbounded = true; | |||
| p.reverse = false; | |||
There was a problem hiding this comment.
This fixes the crash when --reverse is enabled with --index_value.
There was a problem hiding this comment.
I like your review comment explaining how it fixes a particular problem.
kimjh2005
commented
Dec 4, 2020
| if( p.reverse && !point_query && !exact_match ) { | ||
| status_ub = ub_itr->kv_it_prev(&ub_key_size, &ub_value_size); | ||
| if( !point_query && !exact_match ) { | ||
| status_ub = ub_itr->kv_it_prev(&ub_key_size, &ub_value_size); |
There was a problem hiding this comment.
This fixes the incorrect end iterator resulting empty set.
kimjh2005
commented
Dec 4, 2020
| @@ -2326,7 +2328,7 @@ read_only::get_table_rows_result read_only::get_kv_table_rows_context( const rea | |||
| } | |||
|
|
|||
| unsigned int count = 0; | |||
| for( count = 0; cur_time <= end_time && count < p.limit && cmp < 0; cur_time = fc::time_point::now() ) { | |||
| for( count = 0; cur_time <= end_time && count < p.limit && cmp <= 0; cur_time = fc::time_point::now() ) { | |||
There was a problem hiding this comment.
cmp<=0 for inclusive range
linhuang-blockone
approved these changes
Dec 7, 2020
| @@ -2219,6 +2220,7 @@ read_only::get_table_rows_result read_only::get_kv_table_rows_context( const rea | |||
| const string &index_value = *p.index_value; | |||
| p.lower_bound = p.index_value; | |||
| unbounded = true; | |||
| p.reverse = false; | |||
There was a problem hiding this comment.
I like your review comment explaining how it fixes a particular problem.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fixed issues:
-fixed a crash when --reverse and --index_value used at the same time.
-fixed the behavior or end range to be inclusive as in other get_table apis.
Before upper was exclusive [lower, upper), now inclusive [lower, upper]
-fixed a incorrect end of range problem when iterator doesn't have an exact match
Change Type
Select ONE
Consensus Changes
API Changes
Range is now inclusive on both ends like in get_table_rows.
--lower value1 --upper value2 : Return result from value1 to value2 (now value2 is included)
ex) data set:1, 2, 3, 4, 5
--lower 1 --upper 3 will return [1, 2, 3] instead of [1, 2]
-r -lower value1 --upper value2 : In reverse mode, return result from value2 to value1 (value1 is included)
ex) data set:1, 2, 3, 4, 5
-r --lower 1 --upper 3 will return [3, 2, 1] instead of [3, 2]
Documentation Additions