This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix backing store switching issues #9744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linhuang-blockone
requested review from
larryk85,
TimothyBanks,
brianjohnson5972 and
b1bart
linhuang-blockone
changed the title
TimothyBanks
previously approved these changes
Dec 5, 2020
brianjohnson5972
dismissed
TimothyBanks’s stale review
Since there were test issues and a fix since this review, I'm cancelling it to make sure we get current approval.
larryk85
approved these changes
Dec 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This PR fixes the inconsistent handling of switches between Chainbase and RocksDB backing stores.
Switching from a non-clean backing store is not allowed.
The PR also improves the error message.
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions