Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix strict aliasing violations #9761

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Conversation

linhuang-blockone
Copy link
Contributor

@linhuang-blockone linhuang-blockone commented Dec 7, 2020

Change Description

There are a number of uses of reinterpret_cast in database_utils.hpp. They violate the strict aliasing rule.
The fix is using memcpy to assign values between non-compatible types.

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants