This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add log path for unsupported log version exception #9906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libraries/chain/block_log.cpp
Outdated
| @@ -37,6 +37,8 @@ namespace eosio { namespace chain { | |||
| uint32_t version = 0; | |||
| uint32_t first_block_num = 0; | |||
| std::variant<genesis_state, chain_id_type> chain_context; | |||
| fc::path log_path; | |||
|
|
|||
There was a problem hiding this comment.
Just pass the log_path as a parameter to block_log_preamble::read_from() is enough. There's no reason the keep log_path as a member variable.
heifner
approved these changes
Jan 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
For issue: #9871
Change Type
Select ONE:
warn 2021-01-19T17:55:50.003 thread-0 chain_plugin.cpp:1321 plugin_initialize ] 3190001 block_log_unsupported_version: unsupported version of block log
Unsupported version of block log. Block log version is 808464432 while code supports version(s) [1,4], log file: /Users/yue.han/workspace/eosio/develop/bin/dogfooding/data/blocks/blocks.log
{"version":808464432,"min":1,"max":4,"log":"/Users/yue.han/workspace/eosio/develop/bin/dogfooding/data/blocks/blocks.log"}
thread-0 block_log.cpp:57 read_from
error 2021-01-19T17:55:50.003 thread-0 main.cpp:163 main ] 3190001 block_log_unsupported_version: unsupported version of block log
Unsupported version of block log. Block log version is 808464432 while code supports version(s) [1,4], log file: /Users/yue.han/workspace/eosio/develop/bin/dogfooding/data/blocks/blocks.log
{"version":808464432,"min":1,"max":4,"log":"/Users/yue.han/workspace/eosio/develop/bin/dogfooding/data/blocks/blocks.log"}
thread-0 block_log.cpp:57 read_from
rethrow
{}
thread-0 chain_plugin.cpp:1321 plugin_initialize
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions