Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.0.0 #45

Merged
merged 14 commits into from
Jan 18, 2023
Merged

Version 4.0.0 #45

merged 14 commits into from
Jan 18, 2023

Conversation

Eastrall
Copy link
Owner

@Eastrall Eastrall commented Nov 1, 2022

Version 4.0.0

Added

Changes

⚠️ BREAKING CHANGE ⚠️

  • Changed IEncryptionProvider interface to be simpler to use:
    • byte[] Encrypt(byte[] input) instead of TStore Encrypt<TStore, TModel>(TModel dataToEncrypt, Func<TModel, byte[]> converter, Func<Stream, TStore> encoder);
    • byte[] Decrypt(byte[] input) instead of TModel Decrypt<TStore, TModel>(TStore dataToDecrypt, Func<TStore, byte[]> decoder, Func<Stream, TModel> converter);

Other changes

  • Add GitHub action support with build matrix (.NET Core 3.1, .NET 5, .NET 6, .NET 7)
  • Update README.md documentation for creating a custom encryption provider. (Pleas update docs for IEncryptionProvider #37)
  • Update projects to C# 10 and file scoped namespaces

Removals

⚠️ BREAKING CHANGE ⚠️

  • Removing constructor AesProvider(byte[] key, CipherMode mode = CipherMode.CBC, PaddingMode padding = PaddingMode.PKCS7) on AesProvider.
  • Removed dynamic IV support.
    • To add dynamic IV support, you will have to create your own encryption provider.
  • Removed Data Migration support.

Other removals

  • Remove AzureDevOps pipelines.

@Eastrall Eastrall added the enhancement New feature or request label Nov 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@de814ed). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage        ?   94.36%           
=======================================
  Files           ?        6           
  Lines           ?      142           
  Branches        ?       28           
=======================================
  Hits            ?      134           
  Misses          ?        3           
  Partials        ?        5           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Eastrall Eastrall mentioned this pull request Nov 11, 2022
Copy link

@sominola sominola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

)

Copy link

@Uli-Armbruster Uli-Armbruster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. can you ship this?

@Eastrall
Copy link
Owner Author

@Uli-Armbruster I need to run some more tests for byte[] encryption as a Base64 string, I noticed that V3.X has a major issue with this scenario. Encryption process goes well, but decryption process adds some extra 0 bytes to the original value, and unfortunatly there nothing I can do about it. So, I will most likely drop the support for encrypting a byte[] as a Base64 string.

I'll keep you updated on this.

@Uli-Armbruster
Copy link

@Uli-Armbruster I need to run some more tests for byte[] encryption as a Base64 string, I noticed that V3.X has a major issue with this scenario. Encryption process goes well, but decryption process adds some extra 0 bytes to the original value, and unfortunatly there nothing I can do about it. So, I will most likely drop the support for encrypting a byte[] as a Base64 string.

I'll keep you updated on this.

For my understanding: When I have an Entity with a property of type byte[], then there would be under certain circumstances failures in encryption since extra 0 bytes are added?

@Eastrall Eastrall merged commit 0beb736 into main Jan 18, 2023
@Eastrall Eastrall deleted the wip/v4 branch January 18, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants