Fix SASS deprecations #1337
Merged
Fix SASS deprecations #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenjwatkins
commented
Aug 28, 2024
There was a problem hiding this comment.
going to version it since theoretically this could change the CSS output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Changes
SASS introduced a breaking change with nested selectors to be more in line with native CSS. This was causing a lot of noise in our scripts.
This PR updates our SASS to remove the problematic code. Most of the time the declartions in SCSS could simply be moved to the top of the block. With complicated nesting (i.e.
_responsive-props.scss) we have to utilize& { }.We'll need to be mindful of this SCSS change in new work—it may warrant a Stylelint rule if it becomes problematic.
✅ Checklist