Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Prep for v4.6.0 release #237

Merged
merged 2 commits into from
Aug 16, 2024
Merged

[chore] Prep for v4.6.0 release #237

merged 2 commits into from
Aug 16, 2024

Conversation

nwithan8
Copy link
Member

@nwithan8 nwithan8 commented Aug 16, 2024 •
edited
Loading

Description

While this is a bug fix, the fix itself is significant enough from a risk perspective to warrant a minor version bump.

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc.)

@nwithan8 nwithan8 requested a review from a team as a code owner August 16, 2024 19:00
jchen293
jchen293 approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@jchen293 jchen293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a minor version bump as well

@nwithan8 nwithan8 merged commit a4c741f into master Aug 16, 2024
11 checks passed
@nwithan8 nwithan8 deleted the prep_release branch August 16, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchen293 jchen293 jchen293 approved these changes

@Justintime50 Justintime50 Justintime50 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwithan8 @jchen293 @Justintime50