Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Account for new UPS endpoint in carrier account create/update functions #455

Merged
merged 8 commits into from
Jul 12, 2024
Merged

feat: Account for new UPS endpoint in carrier account create/update functions #455

merged 8 commits into from
Jul 12, 2024

Conversation

nwithan8
Copy link
Member

@nwithan8 nwithan8 commented Jul 9, 2024

Description

  • Routes UpsAccount, UpsMailInnovationsAccount, and UpsSurepostAccount create/update requests to the new /ups_oauth_registrations endpoint

Testing

Adds new tests for each, updates previous custom workflow test to use FedEx instead of UPS

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team as a code owner July 9, 2024 21:58
jchen293
jchen293 reviewed Jul 10, 2024
View reviewed changes
src/services/carrier_account_service.js Outdated Show resolved Hide resolved
src/services/carrier_account_service.js Outdated Show resolved Hide resolved
test/services/carrier_account.test.js Outdated Show resolved Hide resolved
test/services/carrier_account.test.js Outdated Show resolved Hide resolved
Justintime50
Justintime50 previously requested changes Jul 10, 2024
View reviewed changes
src/services/carrier_account_service.js Outdated Show resolved Hide resolved
src/services/carrier_account_service.js Outdated Show resolved Hide resolved
test/services/carrier_account.test.js Outdated Show resolved Hide resolved
test/services/carrier_account.test.js Outdated Show resolved Hide resolved
test/services/carrier_account.test.js Outdated Show resolved Hide resolved
jchen293
jchen293 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@jchen293 jchen293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for addressing all the feedback!

@nwithan8 nwithan8 merged commit 5fb49ca into master Jul 12, 2024
14 checks passed
@nwithan8 nwithan8 deleted the ups_oauth branch July 12, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchen293 jchen293 jchen293 approved these changes

@Justintime50 Justintime50 Justintime50 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwithan8 @jchen293 @Justintime50