Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getNextPage in User Service #468

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Fix getNextPage in User Service #468

merged 1 commit into from
Aug 8, 2024

Conversation

jchen293
Copy link
Member

@jchen293 jchen293 commented Aug 8, 2024

Description

Fix getNextPage in User Service where it should use after_id key

Testing

re-record cassette

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@jchen293 jchen293 requested a review from a team as a code owner August 8, 2024 19:42
nwithan8
nwithan8 previously approved these changes Aug 8, 2024
View reviewed changes
@jchen293 jchen293 requested a review from nwithan8 August 8, 2024 19:45
@jchen293 jchen293 merged commit beee810 into master Aug 8, 2024
14 checks passed
@jchen293 jchen293 deleted the child branch August 8, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justintime50 Justintime50 Justintime50 approved these changes

@nwithan8 nwithan8 Awaiting requested review from nwithan8

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchen293 @nwithan8 @Justintime50