Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new smartrate endpoints functions #342

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Add new smartrate endpoints functions #342

merged 2 commits into from
Jul 12, 2024

Conversation

jchen293
Copy link
Member

Description

  • Adds new shipment.recommendShipDate, smartrate.recommendShipDate, and smartrate.estimateDeliveryDate functions

Testing

Add new unit tests

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@jchen293 jchen293 requested a review from a team as a code owner July 11, 2024 21:52
Justintime50
Justintime50 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@Justintime50 Justintime50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: nice work, this is a really clean PR!

@jchen293 jchen293 merged commit be13826 into master Jul 12, 2024
6 checks passed
@jchen293 jchen293 deleted the smartrate_functions branch July 12, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwithan8 nwithan8 nwithan8 approved these changes

@Justintime50 Justintime50 Justintime50 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchen293 @nwithan8 @Justintime50