fix get_next_page_of_children function for User service (#346)

EasyPost · Aug 2, 2024 · 0f0309f · 0f0309f
1 parent 387e1a3
commit 0f0309f
Show file tree

Hide file tree

Showing 4 changed files with 94 additions and 13 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## Next Release
+
+- Fix `get_next_page_of_children` function for User service with correct filter key
+
 ## v9.4.0 (2024-07-24)
 
 - Adds new `Claim` service for filing claims on EasyPost shipments and insurances

diff --git a/easypost/services/user_service.py b/easypost/services/user_service.py
@@ -139,7 +139,7 @@ def get_next_page_of_children(
         self._check_has_next_page(collection=children)
 
         params = {
-            "before_id": children["children"][-1].id,
+            "after_id": children["children"][-1].id,
             "page_size": page_size,
         }
 

diff --git a/tests/cassettes/test_user_children_get_next_page.yaml b/tests/cassettes/test_user_children_get_next_page.yaml
diff --git a/tests/test_user.py b/tests/test_user.py
@@ -1,6 +1,5 @@
 import pytest
 from easypost.constant import (
-    _FILTERS_KEY,
     _TEST_FAILED_INTENTIONALLY_ERROR,
     NO_MORE_PAGES_ERROR,
 )
@@ -105,9 +104,6 @@ def test_user_children_get_next_page(prod_client, page_size):
         first_id_of_second_page = next_page["children"][0].id
 
         assert first_id_of_first_page != first_id_of_second_page
-
-        # Verify that the filters are being passed along for behind-the-scenes reference
-        assert first_page[_FILTERS_KEY] == next_page[_FILTERS_KEY]
     except Exception as e:
         if e.message != NO_MORE_PAGES_ERROR:
             raise Exception(_TEST_FAILED_INTENTIONALLY_ERROR)