Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clap and mysql to fix cargo audit #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simlay
Copy link

@simlay simlay commented Jun 19, 2024

I did a driveby on #15 trying to find something to dunk @thwarted over (nano or bust) but then found myself fixing cargo audit once I was half way done I figured why not finish so here's some free work. I don't use this project nor do I fully know what it does. I do know how to read rust and how to read change logs though.

This PR is updates for clap, mysql and mysql_common to deal with various rustsec issues. Bumping mysql and mysql_common required no changes clap definitely did.

mysql_common somewhere along the way made uuid a non-feature flagged dependency and renamed the time03 feature flag to time in 0.30.

clap updates:

See the clap changelog for more if I missed any.

I also threw in dependabot for cargo and github actions that skip patch versions. Should you choose to merge this, you'll see that the new PRs and maybe this will be less work in the future.

* Removed uuid feature flag
@thwarted
Copy link
Member

I spent a non-trivial amount of time during this change poking at clap to figure out what to replace is_present with, and contains_id only seemed to make sense for more recent versions of clap and I wasn't about to do a full update and remove the use of is_present elsewhere. There was also some oddity with using the StoreTrue value for it that I don't remember now. And I was uncomfortable that this was a negated option but didn't have a better idiom at hand.

@simlay
Copy link
Author

simlay commented Jun 19, 2024

I spent a non-trivial amount of time during this change poking at clap to figure out what to replace is_present with, and contains_id only seemed to make sense for more recent versions of clap and I wasn't about to do a full update and remove the use of is_present elsewhere. There was also some oddity with using the StoreTrue value for it that I don't remember now. And I was uncomfortable that this was a negated option but didn't have a better idiom at hand.

Yeah. I don't know this repo well enough to say my implementation is fully correct. I recall James disliking clap's derive macro (or whatever preceeded clap's derive macro). I think this is because it increased compile times and binary sizes. I personally 🎵like big binaries and I cannot lie🎵 and would use #[derive(clap::Parser)]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants