[DO NOT MERGE] [MM] Intersection Observer #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewCMoya
changed the title
MatthewCMoya
force-pushed
the
feature/intersection-observer
branch
from
feecc0c
to
38af137
Compare
stephenbaldwin
approved these changes
Nov 18, 2019
MatthewCMoya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge until offsets are supported
Description
Currently, our scroll monitor system only allows watching the window.
This is a problem for any sort of scrolling div or modal that an application may be using.
The solution is to use the intersectionObserver API.
It looks like lines were added but the bundle size should be smaller as the bloat is more test lines and types.
PR Requirements
Before requesting review this criteria must be met:
Overall test coverage >= current master?
Documentation included (if any behavioral changes)?
Backwards compatibility (if breaking change)?
Release
Will this pr trigger a release i.e.
versioninpackage.jsonhas been bumped?Screenshots
If U.I. component, include screenshots or video screen capture showing
behavior and responsive styling below.