Unsafe field access #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -572,5 +574,25 @@ static private MethodVisitor insertThrowExceptionForFieldType (MethodVisitor mv, | |||
| mv.visitInsn(ATHROW); | |||
| return mv; | |||
| } | |||
|
|
|||
|
|
|||
| static public FieldAccess getAccessUnsafe(Class<?> type) | |||
There was a problem hiding this comment.
I'd prefer new FieldAccessUnsafe(Class) over putting unsafe related code in FieldAccess.
There was a problem hiding this comment.
All right.And thanks for your notice! I'll try to improve it. Would you like me to write an inner-class in FieldAccess?
There was a problem hiding this comment.
Unsafe would need to be completely separate and accessed in a way that still works when unsafe is not available. However, with unsafe being unsupported in future Java versions, I'm not sure it's worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added field access by sun.misc.Unsafe.