Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build with jdk 9 + 11 #67

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add build with jdk 9 + 11 #67

wants to merge 2 commits into from

Conversation

magro
Copy link
Collaborator

@magro magro commented Jan 1, 2019

Verify compatibility of reflectasm with newer jdks.

Jdk 9+ requires to change the source/target version from 1.5 to 1.6.

I've not verified this locally, let's use travis for validation.

Verify compatibility of reflectasm with newer jdks.
Because 1.5 is no longer supported by jdk 9+
@magro
Copy link
Collaborator Author

magro commented Jan 1, 2019

Build with jdk 11 failed once with

[ERROR]   ClassLoaderTest.testAutoUnloadClassloaders:63 expected:<3> but was:<2>

Rebuilding was successful.

@MartenTrustly
Copy link

Will this solve the issue with future deprecation warnings when using Java 9+? (#64)

@oliemansm
Copy link

@MartenTrustly Was hoping that too, but I don't think so judging by the code and @magro own suggestion in that ticket:

An option might be to create a multi release jar (aka MRJAR) and use a different way for Java 9+ to defineClass (MethodHandles.Lookup.defineClass).

@NathanSweet Any chance of getting this merged and #64 fixed?

@magro
Copy link
Collaborator Author

magro commented Apr 4, 2020

Exactly, this here will not remove the depreciation warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants