Store Genesis Block Payload for view 1 #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenkeyao
approved these changes
Jan 23, 2024
elliedavidson
approved these changes
Jan 23, 2024
bfish713
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Initializes hotshot state with the first block that will be proposed. It's a hack because we don't go through DA on the first view
and the first leader always proposes and empty block.
This PR does not:
Create a proper genesis workflow. Eventually we don't want to special case the first view, only the genesis view should be special (view 0).
Key places to review:
Is this the write place to init the map?
How to test this PR:
To Test I manually logged the decide events in the test harness and saw that always the first view was an empty block (no transactions) and that the payload we initialized the map with logged the exact same thing.