Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILDER] Implement Builder API consumer #2541

Merged
merged 4 commits into from
Mar 15, 2024
Merged

[BUILDER] Implement Builder API consumer #2541

merged 4 commits into from
Mar 15, 2024

Conversation

QuentinI
Copy link
Contributor

@QuentinI QuentinI commented Feb 7, 2024

Closes #2415

This PR:

  • Implements a BuilderClient able to communicate with builders through hs-builder-api
  • Adds a dummy builder, which "builds" empty blocks and adds a test to run BuilderClient against it

This PR does not:

  • Implement more sophisticated HotShot-internal builders (which we do want to do later)
  • Integrate the builder client into HotShot

Key places to review:

crates/task-impls/src/builder.rs
crates/testing/src/block_builder.rs
crates/testing/tests/block_builder.rs

@QuentinI QuentinI changed the title [BUILDER] [WIP] Implement Builder API consumer [BUILDER] Implement Builder API consumer Feb 8, 2024
@move47
Copy link
Contributor

move47 commented Feb 13, 2024

I am not sure whether it is right time to include the recent changes introduced in api responses structure here: EspressoSystems/hs-builder-api#14. @nyospe

If you want to do some development based on these recent changes, please use branch https://github.com/EspressoSystems/hs-builder-api/tree/builder_specific_information for it.

FYI, I have included these changes in the builder side.

@move47
Copy link
Contributor

move47 commented Feb 13, 2024

I am not sure whether it is right time to include the recent changes introduced in api responses structure here: EspressoSystems/hs-builder-api#14. @nyospe

If you want to do some development based on these recent changes, please use branch https://github.com/EspressoSystems/hs-builder-api/tree/builder_specific_information for it.

FYI, I have included these changes in the builder side.

The changes has been merged in main. So, no need to point the a branch now.

@QuentinI QuentinI force-pushed the ag/builder-api branch 4 times, most recently from e347e15 to e8f3095 Compare February 20, 2024 17:28
@QuentinI QuentinI marked this pull request as ready for review February 20, 2024 17:28
bfish713
bfish713 previously approved these changes Feb 27, 2024
@QuentinI
Copy link
Contributor Author

@bfish713 should be ready for merge now

@QuentinI QuentinI merged commit 9a5e1de into main Mar 15, 2024
13 checks passed
@QuentinI QuentinI deleted the ag/builder-api branch March 15, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUILDER] - Builder API consumer
4 participants