[TECH-DEBT] Add View Sync Timeout to Config #2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparr721
previously approved these changes
Mar 15, 2024
Cargo.toml
Outdated
| "uds", | ||
| "websocket", | ||
| "yamux", | ||
| "macros", |
There was a problem hiding this comment.
What did you run to format this? Is it a vscode command?
There was a problem hiding this comment.
Actually been trying out neovim and it was doing the toml formatting
There was a problem hiding this comment.
Oooh I might bug you for your config later
| let randomized_view_number: u64 = rng.gen(); | ||
| let index = (randomized_view_number % self.nodes_with_stake.len() as u64) as usize; | ||
| let mut rng: StdRng = rand::SeedableRng::seed_from_u64(*view_number); | ||
| let randomized_view_number: usize = rng.gen(); |
Mind taking a look at the other PR? |
jparr721
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1472
This PR:
Adds a view sync timeout duration to the config and makes the default a less time than the view timeout.
This PR does not:
Shouldn't change anything else
Key places to review:
Are the defaults reasonable