-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TECH-DEBT] Add View Sync Timeout to Config #2777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Though I think I'll need to re-approve after your types PR goes in.
Cargo.toml
Outdated
"uds", | ||
"websocket", | ||
"yamux", | ||
"macros", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What did you run to format this? Is it a vscode command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually been trying out neovim and it was doing the toml formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooh I might bug you for your config later
let randomized_view_number: u64 = rng.gen(); | ||
let index = (randomized_view_number % self.nodes_with_stake.len() as u64) as usize; | ||
let mut rng: StdRng = rand::SeedableRng::seed_from_u64(*view_number); | ||
let randomized_view_number: usize = rng.gen(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Mind taking a look at the other PR? |
Closes #1472
This PR:
Adds a view sync timeout duration to the config and makes the default a less time than the view timeout.
This PR does not:
Shouldn't change anything else
Key places to review:
Are the defaults reasonable