-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CX_CLEANUP] - Deprecate and remove Storage trait and usages #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparr721
commented
Mar 15, 2024
jparr721
commented
Mar 15, 2024
bfish713
previously approved these changes
Mar 18, 2024
bfish713
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2788
We have a lot of old dead code because conensus used be completely state driven, i.e. blocks were state updates, it used to be very explicitly one view at a time, not event driven. One of these artifacts exists as the Storage trait, found here.
As a result of the need to support storing DA, VID diseperals, and later work by sequencer (tracking: #2621), we need to deprecate and remove this type from the code and modernize its name. This issue is preliminarily responsible for only the removal of this type from the code.
This PR:
HotShot-Types
MemoryStorage
AtomicStorage
node_types.rs
,crates/hotshot/lib.rs
, and the associated test generator files to remove all usages of the storage type.This PR does not:
While the intention is to pave the way for the new storage type, we shrink the scope here by first removing all of the cruft of the old code.
Key places to review:
All logic where code was touched that affects production environments, especially
node_types.rs
andlib.rs