Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CX_CLEANUP] - Deprecate and remove Storage trait and usages #2790

Merged
merged 11 commits into from
Mar 18, 2024

Conversation

jparr721
Copy link
Contributor

Closes #2788

We have a lot of old dead code because conensus used be completely state driven, i.e. blocks were state updates, it used to be very explicitly one view at a time, not event driven. One of these artifacts exists as the Storage trait, found here.

As a result of the need to support storing DA, VID diseperals, and later work by sequencer (tracking: #2621), we need to deprecate and remove this type from the code and modernize its name. This issue is preliminarily responsible for only the removal of this type from the code.

This PR:

  • Removes the type from HotShot-Types
  • Removes MemoryStorage
  • Remove sAtomicStorage
  • Updates node_types.rs, crates/hotshot/lib.rs, and the associated test generator files to remove all usages of the storage type.

This PR does not:

While the intention is to pave the way for the new storage type, we shrink the scope here by first removing all of the cruft of the old code.

Key places to review:

All logic where code was touched that affects production environments, especially node_types.rs and lib.rs

Cargo.toml Outdated Show resolved Hide resolved
@jparr721 jparr721 requested review from shenkeyao and removed request for lukaszrzasik March 15, 2024 20:02
bfish713
bfish713 previously approved these changes Mar 18, 2024
@jparr721 jparr721 merged commit 59703be into main Mar 18, 2024
13 checks passed
@jparr721 jparr721 deleted the jp/issue-2788 branch March 18, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CX_CLEANUP] - Deprecate and remove Storage trait and usages
2 participants