-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CX-CLEANUP] - DA Integrated Storage #2799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, but lets give @jbearer some time to answer your question
…r, fix old da test
inner: Arc<RwLock<TestStorageState<TYPES>>>, | ||
|
||
/// `should_return_err` is a testing utility to validate negative cases. | ||
pub should_return_err: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open to thoughts here. See the tests below for examples. I just need a cheesy "fail immediately" system that does not change the interface. The idea here is that I just want to make sure that any logical changes can catch a regression in the failure case for an append
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is fine, it's just a dummy type for our tests anyway
// Run view 1 (the genesis stage). | ||
let view_1 = TestScriptStage { | ||
inputs: vec![ | ||
ViewChange(ViewNumber::new(1)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is copied direct from the test as it was just to maintain parity. I've been trying to modernize tests as I touch them.
Closes #2621
We want to integrate a persistent storage interface within HotShot to enable the application to manage data storage effectively. This feature aims to address potential data storage issues (e.g., full disk space) that can prevent nodes from storing DA blobs or VID shares.
This PR:
Storage
TraitStorage
inSystemTask
's initBlockPayload
fromLeaf
and associated types. #2808)This code also implements a number of changes to introduce a
TestBlockStorage
type for use in the various testing components.This PR does not:
Key places to review:
All of the tests and test interface changes. I had to update the
view_generator
to support the various DA related things that we wanted to add.