-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Consensus2] - Decouple quorum proposal task #3151
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to jp/decouple-quorum_proposal_task
…to jp/decouple-quorum_proposal_task
shenkeyao
requested changes
May 16, 2024
jparr721
commented
May 20, 2024
jparr721
commented
May 20, 2024
shenkeyao
previously approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a comment about reordering code.
shenkeyao
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3171
This PR:
Right now the quorum proposal task relies on calling the existing consensus functions, but isolates the call site so that way it can exist in an idempotent manner. This has created some issues due to the need to keep backwards compatibility with the consensus task. Instead, we will author our own new logic and only reuse functions that have limited scope. Specifically:
consensus
task unless the functionality will live on in the new tasksThis PR does not:
Key places to review:
ValidatedStateUpdated
, as this method is a gating requirement to be able to propose. Does it make sense to gate on this method? This updatesvalidated_state_map
, which we use when we propose.QuorumProposalValidated
referencing the right proposal and leaf?test_view_1
test evaluating the right genesis views?Also PLEASE look at the design doc in notion! It features a deep-dive of all the changes as well as their motivation.