Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[METRICS] - Individual node health #3235

Merged
merged 7 commits into from
May 31, 2024
Merged

[METRICS] - Individual node health #3235

merged 7 commits into from
May 31, 2024

Conversation

shenkeyao
Copy link
Member

Closes #3222.

This PR:

  • Adds view_duration_as_leader and number_of_timeouts_as_leader metrics.
  • Adds cur_view_time field to the task states, which is needed for the view_duration_as_leader metric.
  • Updates the update_view function to take additional arguments to update view_duration_as_leader when being a leader.
  • Removes unused NextLeaderViewTimeout event.

This PR does not:

  • Modify existing metrics.

Key places to review:

  • Whether the metrics are updated correctly in:
    • crates/task-impls/src/consensus/mod.rs
    • crates/task-impls/src/consensus/view_change.rs
    • crates/task-impls/src/consensus2/handlers.rs

@shenkeyao shenkeyao requested a review from jbearer May 29, 2024 03:41
jparr721
jparr721 reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@jparr721 jparr721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing otherwise lgtm

crates/hotshot/Cargo.toml Outdated Show resolved Hide resolved
dailinsubjam
dailinsubjam previously approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@dailinsubjam dailinsubjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shenkeyao shenkeyao merged commit fc31166 into main May 31, 2024
24 checks passed
@shenkeyao shenkeyao deleted the keyao/metrics-individual branch May 31, 2024 00:32
ss-es pushed a commit that referenced this pull request May 31, 2024
@shenkeyao @ss-es
[METRICS] - Individual node health (#3235)
d3ebdff 
* Add metrics

* Fix build

* fmt

* Use workspace version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparr721 jparr721 jparr721 left review comments

@bfish713 bfish713 bfish713 approved these changes

@dailinsubjam dailinsubjam dailinsubjam left review comments

@jbearer jbearer Awaiting requested review from jbearer

@ss-es ss-es Awaiting requested review from ss-es ss-es is a code owner

@elliedavidson elliedavidson Awaiting requested review from elliedavidson

Assignees

@dailinsubjam dailinsubjam

@jbearer jbearer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[METRICS] - Individual node health
5 participants
@shenkeyao @bfish713 @dailinsubjam @jparr721 @jbearer