Fix Libp2p Success Test #3285
Merged
Fix Libp2p Success Test #3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfish713
previously approved these changes
Jun 6, 2024
jparr721
commented
Jun 6, 2024
| @@ -418,11 +412,7 @@ impl<TYPES: NodeType, I: NodeImplementation<TYPES>> QuorumVoteTaskState<TYPES, I | |||
| return; | |||
| } | |||
|
|
|||
| debug!( | |||
There was a problem hiding this comment.
I added these two logs when debugging, but the event is mostly None so they're just noise.
bfish713
approved these changes
Jun 6, 2024
bfish713
requested changes
Jun 6, 2024
bfish713
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
Removes the gate on the current proposal's view for the libp2p test.
This PR does not:
Does not fix the failure test case.
Key places to review: