-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CATCHUP] Fetch Proposals in Dependecny Task #3339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
let sender = self.sender.clone(); | ||
let consensus = Arc::clone(&self.consensus); | ||
async_spawn(async move { | ||
fetch_proposal(high_qc_view_number, sender, memberhsip, consensus).await |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come this is an async spawn instead of just calling? It looks like the method doesn't do anything long-running?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fetch could be potentially very slow (500ms) and this caller isn't expecting the result directly back, in the mean time we might get the ValidatedStateUpdated
event we need before the request for proposal ever even finishes
Closes #3244
This PR:
fetch_proposal
functionThis PR does not:
Key places to review: